Block the package from building on iOS-derived platforms #30
+4
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lynchsft
approved these changes
Apr 28, 2025
|
@iCharlesHu Can I get an approval, please? |
itingliu
reviewed
May 12, 2025
| @@ -166,6 +166,9 @@ extension Configuration { | |||
| error: Error, | |||
| errorPipe: CreatedPipe | |||
| ) throws -> Execution<Output, Error> { | |||
| #if !os(macOS) | |||
There was a problem hiding this comment.
The motivation of this change makes sense, but this runtime error inside this function is very non obvious to me.
|
Discussed offline: instead of allowing This is the same workaround we used in https://github.com/swiftlang/swift-corelibs-foundation/blob/873a14c644bf194a5dc961b925a626070a141706/Package.swift#L186 to signify that we do not build on iOS. |
Process spawning is not available there. Also remove a couple overly-specific platform conditions in tests that would be incorrect on other Unix-like platforms such as Android and FreeBSD.
jakepetroules
force-pushed
the
platform-ports
branch
from
dce4662 to
67e3d7a
Compare
|
OK, I've made those adjustments. |
jakepetroules
changed the title
lynchsft
approved these changes
May 17, 2025
iCharlesHu
approved these changes
May 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Process spawning is not available there. Also remove a couple overly-specific platform conditions in tests that would be incorrect on other Unix-like platforms such as Android and FreeBSD.